Update gocommon #740
Update gocommon #740
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
=======================================
Coverage 74.68% 74.68%
=======================================
Files 111 111
Lines 13279 13279
=======================================
Hits 9917 9917
Misses 2649 2649
Partials 713 713 ☔ View full report in Codecov by Sentry. |
| @@ -11,7 +11,7 @@ import ( | |||
| ) | |||
|
|
|||
| var testChannels = []courier.Channel{ | |||
| test.NewMockChannel("8eb23e93-5ecb-45ba-b726-3b064e0c56ab", "MB", "2020", "BR", map[string]any{"username": "zv-username", "password": "zv-password"}), | |||
| test.NewMockChannel("8eb23e93-5ecb-45ba-b726-3b064e0c56ab", "MB", "2020", "US", map[string]any{"username": "zv-username", "password": "zv-password"}), | |||
There was a problem hiding this comment.
@norkans7 so seems 12067799294 is a valid local Brazilian number.. and if you pass BR then gocommon currently gives you back +5512067799294 rather than +12067799294.. I think that's ok.. this is a weird test passing US numbers for BR channel.
I guess if we know a channel is giving us international numbers we could manually add + before parsing... or don't pass the channel country because the channel in that case doesn't really have a country.
There was a problem hiding this comment.
Yes, the BR was from the test copied and pasted
No description provided.