Fix WA templating generation and add tests #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Mar 15, 2024
| } else { | ||
| component := &Component{Type: "button", Index: strings.TrimPrefix(k, "button."), SubType: "quick_reply"} | ||
| component.Params = append(component.Params, &Param{Type: "payload", Payload: p.Value}) | ||
| template.Components = append(template.Components, component) |
There was a problem hiding this comment.
isn't this adding a button component for every param in a button ?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
==========================================
+ Coverage 74.17% 74.41% +0.24%
==========================================
Files 110 110
Lines 13330 13335 +5
==========================================
+ Hits 9887 9923 +36
+ Misses 2727 2690 -37
- Partials 716 722 +6 ☔ View full report in Codecov by Sentry. |
norkans7
approved these changes
Mar 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.