Update I*,J*, K* handlers to use new send #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #701 +/- ##
==========================================
+ Coverage 74.20% 74.32% +0.12%
==========================================
Files 98 98
Lines 12922 12870 -52
==========================================
- Hits 9589 9566 -23
+ Misses 2632 2599 -33
- Partials 701 705 +4 ☔ View full report in Codecov by Sentry. |
rowanseymour
requested changes
Feb 27, 2024
handlers/infobip/handler.go
Outdated
| } | ||
|
|
||
| groupID, err := jsonparser.GetInt(respBody, "messages", "[0]", "status", "groupId") | ||
| if err != nil || (groupID != 1 && groupID != 3) { | ||
| clog.Error(courier.ErrorResponseValueUnexpected("groupId", "1", "3")) | ||
| return status, nil | ||
| return courier.ErrFailedWithReason("", "unexpected groupId value") |
There was a problem hiding this comment.
should never have both a channel log and a terminal error
There was a problem hiding this comment.
courier.ErrFailedWithReason is for passing back an external code that RP can link to a page with... this looks like it should ErrResponseUnexpected
rowanseymour
requested changes
Feb 28, 2024
handlers/infobip/handler.go
Outdated
| } | ||
|
|
||
| groupID, err := jsonparser.GetInt(respBody, "messages", "[0]", "status", "groupId") | ||
| if err != nil || (groupID != 1 && groupID != 3) { | ||
| clog.Error(courier.ErrorResponseValueUnexpected("groupId", "1", "3")) | ||
| return status, nil | ||
| return courier.ErrFailedWithReason("", "unexpected groupId value") |
There was a problem hiding this comment.
courier.ErrFailedWithReason is for passing back an external code that RP can link to a page with... this looks like it should ErrResponseUnexpected
handlers/justcall/handler.go
Outdated
| } | ||
| if respStatus != "success" { | ||
| return status, nil | ||
| return courier.ErrFailedWithReason("", "got non-success status") |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.