Add support to receive button text from Twilio WhatsApp #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #405 +/- ##
==========================================
+ Coverage 71.99% 72.00% +0.01%
==========================================
Files 95 95
Lines 8294 8297 +3
==========================================
+ Hits 5971 5974 +3
Misses 1731 1731
Partials 592 592
Continue to review full report at Codecov.
|
norkans7
commented
Jan 19, 2022
handlers/twiml/twiml_test.go
Outdated
| waReceivePrefixlessURN = "ToCountry=US&ToState=CA&SmsMessageSid=SM681a1f26d9ec591431ce406e8f399525&NumMedia=0&ToCity=&FromZip=60625&SmsSid=SM681a1f26d9ec591431ce406e8f399525&FromState=IL&SmsStatus=received&FromCity=CHICAGO&Body=Msg&FromCountry=US&To=%2B12028831111&ToZip=&NumSegments=1&MessageSid=SM681a1f26d9ec591431ce406e8f399525&AccountSid=acctid&From=%2B14133881111&ApiVersion=2010-04-01" | ||
| ) | ||
|
|
||
| var testCases = []ChannelHandleTestCase{ | ||
| {Label: "Receive Valid", URL: receiveURL, Data: receiveValid, Status: 200, Response: "<Response/>", | ||
| Text: Sp("Msg"), URN: Sp("tel:+14133881111"), ExternalID: Sp("SMe287d7109a5a925f182f0e07fe5b223b"), | ||
| PrepRequest: addValidSignature}, | ||
| {Label: "Receive Button Valid", URL: receiveURL, Data: receiveButtonIgnored, Status: 200, Response: "<Response/>", |
There was a problem hiding this comment.
Here the channel is not whatsapp so we should ignore the ButtonText and use the Body
norkans7
force-pushed
the
TWA-buttons-receive
branch
from
edc523a to
54ca176
Compare
rowanseymour
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.