Fix bulk status updates #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #398 +/- ##
=======================================
Coverage 71.71% 71.71%
=======================================
Files 95 95
Lines 8256 8256
=======================================
Hits 5921 5921
Misses 1746 1746
Partials 589 589
Continue to review full report at Codecov.
|
norkans7
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Struggling to find a good way to test this.. the status update was successful, but then it was failing to get the returned id, so so it would call the error handler of the status committer... which would try to spool the update, but that would also fail because the spool directory doesn't exist, but all that is swallowed by the tests.