Adds the Africa's Talking 'Expired' Status in Its Handler #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the 'Expired' status from Africa's Talking which seems to be thrown but isn't handled. Courier currently throws the following error when it encounters this status: time="2021-11-10T10:29:10+03:00" level=info msg="request errored" channel_uuid=<UUID> elapsed_ms=0.109525 error="unknown status 'Expired', must be one of 'Success','Sent', 'Buffered','Rejected' or 'Failed'" url=/c/at/<UUID>/status Mark messages that have this status as failed as it doesn't appear messages that have this status get delivered to users. Signed-off-by: Jason Rogena <[email protected]>
rowanseymour
approved these changes
Nov 10, 2021
Codecov Report
@@ Coverage Diff @@
## main #387 +/- ##
=======================================
Coverage 71.42% 71.42%
=======================================
Files 94 94
Lines 8276 8276
=======================================
Hits 5911 5911
Misses 1762 1762
Partials 603 603
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the 'Expired' status from Africa's Talking which seems
to be thrown but isn't handled. Courier currently throws the following
error when it encounters this status:
time="2021-11-10T10:29:10+03:00" level=info msg="request errored"
channel_uuid= elapsed_ms=0.109525 error="unknown status
'Expired', must be one of 'Success','Sent', 'Buffered','Rejected'
or 'Failed'" url=/c/at//status
Mark messages that have this status as failed as it doesn't appear
messages that have this status get delivered to users.
Signed-off-by: Jason Rogena [email protected]