New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: configure for msvs 2015 #164

Open

christianchown wants to merge 1 commit into nwjs:node-gyp-3.6.2 from christianchown:fix/configure-msvs-2015

+1 −1

christianchown commented May 15, 2024

966ca06 added support for VS 2017/2019, but introduced an error for VS 2015. createConfigFile is called without a vsInfo for 2015, causing

> nw-gyp configure --msvs_version=2015
...
gyp verb build/config.gypi creating config file
gyp ERR! UNCAUGHT EXCEPTION
gyp ERR! stack TypeError: Cannot read property 'versionYear' of undefined

Fix is to only modify the env for windows if vsInfo is supplied


          fix: configure for msvs 2015

2dafdfe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet