Rename generically named sway functions #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR helps further along #30 |
midirhee12
changed the title
|
Convert this PR to draft, please. I can't focus on reviewing every step, as I'm trying to do my own job at the same time. |
|
Btw, this PR doesn't require any testing for riverwm. It should be functionally the same as current master but with some minor renaming of things. |
|
I am aware of this. |
|
I assume since there's been no changes for the last month that it is probably ready for review. I can change it back to draft if it needs more changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some functions that had
_hyprand the sway equivalent did not have_swayat the end. This leads the reader of the code to believe that it is generically used for both wayland compositors. So I have renamed all occurrences to respect that all sway related functions shall end with_swayinstead.