Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added WSL Troubleshooting and provided a solution to a common problem (fixed typos) #2961

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

mattjaf
Copy link
Contributor

@mattjaf mattjaf commented Dec 1, 2022

hopefully this fixes the indent issue for the test I was failing in my last PR

closes #2958

@ljharb
Copy link
Member

ljharb commented Dec 1, 2022

oof, each PR opened is a permanent ref on the repo :-/ let's keep this one open and I can help you resolve the issue.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great!

Tests are broken on master right now, but once fixed, I'll rebase and land this.

README.md Show resolved Hide resolved
@ljharb ljharb added OS: windows installing node Issues with installing node/io.js versions. informational labels Dec 1, 2022
@ljharb ljharb merged commit 59f448d into nvm-sh:master Dec 23, 2022
@mattjaf
Copy link
Contributor Author

mattjaf commented Dec 23, 2022

How come my name isn't showing up on the contributors list?

@ljharb
Copy link
Member

ljharb commented Dec 24, 2022

I'm not sure - Github shows you as the commit author. If you mean the contributors list on the repo that's capped at 100 contributors, there'll be lots of contributors with a single commit that don't show up there - since the last 3 people have 1 commit, you'd need 2 commits to guarantee showing up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
informational installing node Issues with installing node/io.js versions. OS: windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It is not installing on wsl windows 11
2 participants