Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[readme] Update Alpine Linux Section #2896

Merged
merged 1 commit into from
Oct 8, 2022
Merged

[readme] Update Alpine Linux Section #2896

merged 1 commit into from
Oct 8, 2022

Conversation

luni-moon
Copy link
Contributor

@luni-moon luni-moon commented Sep 27, 2022

PR Changes

Commit 1f2e567

  • Update install directions to include python3, instead of python2, which is deprecated since Alpine 3.13.

Commit da6ba1e

  • Add both install scripts, depending on different Alpine versions being ran, at request
  • Added a side note for users wanting to run Alpine 3.5 - 3.12 regarding older versions of NodeJS

Commit 3f682a5 & af32ff1

  • Update the note regarding Alpine versions supporting which NodeJS versions

Fixes #2895.

- Update install directions to include `python3`, instead of `python2`, which is deprecated since Alpine 3.13.
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

All PRs are blocked until tests are fixed on master, but I'll land this once they are!

@ljharb ljharb changed the title Update Alpine Linux Section in README [readme] Update Alpine Linux Section Oct 8, 2022
@ljharb ljharb merged commit 28b3b0e into nvm-sh:master Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alpine's Python 2 Package is Deprecated
2 participants