[Fix] nvm install: show proper version in .nvmrc install instructions
#2770
+71
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Mar 22, 2022
ljharb
requested changes
Mar 25, 2022
Sure @ljharb, will get right on it! |
deepakchethan
force-pushed
the
feat/hide-version-info-nvm-use-with-nvmrc
branch
from
40e2f8d
to
0d56b17
Compare
deepakchethan
changed the title
|
Hello @ljharb, I have fixed the nvm run as well and added test cases for it. Please review it whenever you are free. Thanks! |
ljharb
reviewed
Mar 29, 2022
test/slow/nvm run/Running 'nvm run' should pick up .nvmrc version
Show resolved
Hide resolved
test/slow/nvm use/Running 'nvm use' with nvmrc containing not intalled version
Show resolved
Hide resolved
deepakchethan
force-pushed
the
feat/hide-version-info-nvm-use-with-nvmrc
branch
from
a3993c1
to
6bc56d4
Compare
|
Hello @ljharb, I have made all the suggested changes. Please let me know if you need me to do some other changes. Thanks! |
1 similar comment
|
Hello @ljharb, I have made all the suggested changes. Please let me know if you need me to do some other changes. Thanks! |
ljharb
changed the title
nvm install: show proper version in .nvmrc install instructions
ljharb
force-pushed
the
feat/hide-version-info-nvm-use-with-nvmrc
branch
from
d024482
to
9e884b8
Compare
|
When will we release this? |
Closed
|
Python 2? Good luck! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We skip showing version only if we have
.nvmrcwith value and runsnvm useornvm run. Ifnvm use v17ornvm run v17 app.jsis used we still show the version as seen in the screenshot:nvm use:
nvm run:
Fixes #2701. Fixes #2775.