[spam] #2735
Closed
[spam] #2735
+19,516
−1,267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow newbies to get a quick understanding of how `nvm` works right from the start.
This uses the npm package `markdown-link-check` to check if all the links in the documentation are alive.
Since markdown-link-check hasn't support relative links, to make the test passed, move this link to use absolute URL so that we can introduce the new test. cc tcort/markdown-link-check#10
… exits on `-e` in a test. See https://gist.github.com/ljharb/6e70a79ac5fcf11a8b9de654a88642aa for details.
- fix test 'Running "nvm ls" should display all installed versions.': only expect versions created by this test, but no versions created by other tests
- Only works for common aliases like `default`, `system`, `node`, `lts/*`, `iojs` etc. - Prevent unnecessary running of `nvm use`
Adds the following information to the "Migrating global packages while installing" section: - notification that the npm package is explicitly not updated when using the --reinstall-packages-from flag - information about the --latest-npm flag - recovery instructions if a user has already updated node with an incompatible npm version
With the environment variable XDG_CONFIG_HOME set, the installation script uses the directory $XDG_CONFIG_HOME/nvm now. Before the change the variable's value with "/nvm" cut off was used, which usually results in an installation without any subdirectory.
If the node version is below 16.0.0 then nvm will select x86_64 architecture, else arm64 architecture.
`nvm install` fails with "Binary download failed, trying source" when - running on Bash; - errtrace (`set -E`) is enabled; - an ERR trap uses `exit` to return a non-zero status; and - /sbin/init doesn't exist. Resolved by moving `ls -dl /sbin/init` to the following `if` statement. In this context, returning non-zero isn't an error and the ERR trap isn't executed.
|
👍😍 |
|
@ImaginalaticWizardry please don't open PRs at all until you understand how github works, but also this and #2736 are both spam. |
ljharb
added
the
non-issue / invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to figure this out.