-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] exclude expired LetsEncrypt CA #2623
Conversation
Worth a shot! I just tried https://app.travis-ci.com/github/nvm-sh/nvm/jobs/541600178 and it didn't work, but this is slightly different. |
Sadly no, same failure :-/ Let's keep this open tho and use it for experimentation. |
workaround for TravisCI's ubuntu 16.04
c413b8a
to
ca339bb
Compare
I think I've fixed it by replacing
with
in thanks for the nerd snipe :) |
ooh! thank you!! travis folks also just suggested: i'm going to try that real quick to see if that works, because that'll be a bit less hacky than the sed :-) |
Their suggestion fixes the curl tests, but not the wget tests. I'm waiting to hear back from them. |
Going to go ahead and land just your fix, and we can iterate on travis' suggestion later. Thanks! |
🤷♂️ who knows if this works lets find out