[Fix] bash_completion: be robust when cd is overridden

[giladbarnea]

Bug:

If cd is patched (overridden) and prints something to stdout/stderr, completing nvm use with tab-tab erroneously displays this output alongside the completion options.

Steps to reproduce:

# Patch cd to print arbitrary text:
function cd(){ echo EXTRA INFORMATION IN MY FACE; command cd "$@"; }
nvm use <TAB> <TAB>

Completion words should be e.g
default EXTRA FACE IN INFORMATION iojs MY node stable unstable v14.17.6

Fix:

This is fixed if function __nvm_aliases in bash_completion uses command cd instead of bare cd.

[ljharb]

Thanks, seems great to me.

[giladbarnea]

Thanks, seems great to me.

Should I delete the branch now?

[ljharb]

That’s up to you, it’s your fork - but yes, typically the branches are deleted after the PR is merged.

[giladbarnea]

That’s up to you, it’s your fork - but yes, typically the branches are deleted after the PR is merged.

Alright, deleted. Thanks for nvm-sh!