Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] nvm_ls_remote_index_tab: handle long version lists #2581

Merged
merged 2 commits into from
Sep 4, 2021
Merged

[Fix] nvm_ls_remote_index_tab: handle long version lists #2581

merged 2 commits into from
Sep 4, 2021

Conversation

kstolp
Copy link
Contributor

@kstolp kstolp commented Sep 4, 2021

Fixes #2578

ljharb
ljharb approved these changes Sep 4, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to ask for a regression test, but it turns out if i merely update nvm's test mocks, the lists become long enough to trigger this error on travis, and your fix fixes it. Thanks!

(will merge if tests pass)

@ljharb ljharb merged commit 291c7c4 into nvm-sh:master Sep 4, 2021
@ljharb ljharb mentioned this pull request Sep 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LTS aliases missing / don't get created
2 participants
@kstolp @ljharb