Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in README.md regarding docker image base in Dockerfile #2573

Merged
merged 1 commit into from
Aug 30, 2021
Merged

fix: typo in README.md regarding docker image base in Dockerfile #2573

merged 1 commit into from
Aug 30, 2021

Conversation

vomaksh
Copy link
Contributor

@vomaksh vomaksh commented Aug 30, 2021

Issue #2572

@vomaksh
Copy link
Contributor Author

vomaksh commented Aug 30, 2021

@ljharb

I have recently witnessed a PR that you have approved where Dockerfile base is changed from 16.04 to 18.04.
I have commented in #2571.
So, should I let this PR open or should I update 14.04 to 18.04?

@ljharb
Copy link
Member

ljharb commented Aug 30, 2021

Definitely leave this open; an unmerged PR is permanent pollution on a repo. I'll land this first, and then we can update the readme in #2571 before landing it.

@ljharb ljharb merged commit 62d45af into nvm-sh:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
informational
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vomaksh @ljharb