Detect correct profile in install.sh based on $SHELL var #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Aug 12, 2021
ljharb
added
the
installing nvm: profile detection
|
Converted to single bracket test. I'll look into adding tests for this behaviour. |
|
Updated the tests. Do you think it looks good now? |
ljharb
approved these changes
Aug 21, 2021
ljharb
force-pushed
the
better-install-detect-profile
branch
from
9d4917e
to
e98e9d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to detect the users default shell rather than the shell the install script is running in, which will always be
bashif following install instructions. Fixes #2555