[Fix] check if compinit is called before calling it
#2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not actually sure if there's a non-interactive way to test completions. If so, adding tests - one that calls If there's no way to test it non-interactively, then we'd need to verify these changes manually in zsh (and bash, just to make sure the syntax is valid) |
|
Sure. I'm not bash guru, sorry can't help with this. Let me know if there's anything else I can help with. |
ljharb
approved these changes
Apr 16, 2021
ljharb
force-pushed
the
GH-2489-check-compinit-called
branch
from
fcb51be
to
117486d
Compare
ljharb
changed the title
compinit is called before calling it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #2489. Not sure about testing, didn't do anything. Please advise me on how to do it.