Make it work on Windows with WSL, MSYS, Cygwin

[nmarghetti]

No description provided.

[ljharb]

This is an unexpected and potentially very large feature to add.

i could use more explanation, but also, this will definitely need tests so that windows support isn’t accidentally broken later.

[ljharb]

This PR sjould also add CI that runs in windows as well (using Github Actions, ideally).

[nmarghetti]

I will try to add a CI with GitHub action to test MSYS, Cygwin and WSL

[nmarghetti]

I managed to add a CI for WSL and MSYS.

[ljharb]

nvm_ensure_posix_path and nvm_install_binary_extract both need unit tests.

[ljharb]

I extracted out d396181 and 7f6c0c0 and landed them on master, and then rebased this.

[ljharb]

@nmarghetti did you mean to rebase out everything except the last test?

[nmarghetti]

@nmarghetti did you mean to rebase out everything except the last test?

I just added this commit to ensure the PR passes (as I am on Windows, I wanted to be sure).
Now that I know this commit is ok, I am adding the other one too ;)

[nmarghetti]

I will update it again to add Windows test for nvm_is_version_installed.
Also, should I remove nvm_windows_drive_posix and nvm_ensure_posix_path ?
If we use

NVM_CONFIG_VALUE="$(cd "$NVM_CONFIG_VALUE" 2>/dev/null && pwd)"

instead of

NVM_CONFIG_VALUE="$(nvm_ensure_posix_path "$NVM_CONFIG_VALUE")"

then it is not needed anymore, but it might still be useful later (not really sure if there are not other places where it needs to convert some Windows path)

[nmarghetti]

I have added a "Cleanup" commit to remove nvm_windows_drive_posix and nvm_ensure_posix_path.
Should I squash that commit or should I remove that commit ?

[nmarghetti]

In the end I squashed it, I still have the code on another branch if needed...

[ljharb]

Sounds great. I’ll likely end up rearranging the commits a bit later anyways :-)

[nmarghetti]

@ljharb what would prevent it to be integrated ?

[ljharb]

master's been broken for a few weeks; it's fixed now. i'll rebase and take a look.

[ljharb]

This is a big one, thanks.

If it ends up not producing a flood of bug reports from windows users who've tried it, I owe you a beer or five :-)

[PabloSzx]

@ljharb when are you planning to release it?

[ljharb]

When I have time to handle the incoming bug reports.