[Fix] nvm_die_on_prefix: filter prefixed env vars on name only, ignoring values
#2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdwint
force-pushed
the
fix_die_on_prefix
branch
2 times, most recently
from
de470fc to
ed5069a
Compare
|
Yes, we definitely should. Since I'm unable to reproduce #2360 on my own machine, that suggests it's more complicated than just "zsh" or "arch" etc, so I think it's important to have a test that captures it. |
ljharb
reviewed
Nov 29, 2020
nvm.sh
Outdated
| @@ -2352,7 +2352,7 @@ nvm_die_on_prefix() { | |||
| # here, we avoid trying to replicate "which one wins" or testing the value; if any are defined, it errors | |||
| # until none are left. | |||
| local NVM_NPM_CONFIG_PREFIX_ENV | |||
| NVM_NPM_CONFIG_PREFIX_ENV="$(command env | nvm_grep -i NPM_CONFIG_PREFIX | command tail -1 | command awk -F '=' '{print $1}')" | |||
| NVM_NPM_CONFIG_PREFIX_ENV="$(command awk 'BEGIN { for (name in ENVIRON) if (toupper(name) == "NPM_CONFIG_PREFIX") { print name; break } }')" | |||
There was a problem hiding this comment.
i know so little about awk :-) this seems like a great improvement.
|
cc @qomosoloto @ivancevich @ArmanMazdaee @zhengdai @pmourer can any of you test with this PR to make sure it doesn't reintroduce #2360? |
mdwint
force-pushed
the
fix_die_on_prefix
branch
from
ed5069a to
b16b387
Compare
ljharb
force-pushed
the
fix_die_on_prefix
branch
from
b16b387 to
4879ebd
Compare
|
@mdwint i've rebased this; can you take another look and made sure i resolved the conflicts correctly? |
|
Hi @ljharb. Yes, this looks right to me. |
ljharb
force-pushed
the
fix_die_on_prefix
branch
from
4879ebd to
93e0070
Compare
ljharb
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2367.
I expect this to be more robust than before, since it only considers the names of environment variables, not their values.
@ljharb Should we try to reproduce #2360 to test for regressions?