-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] Print all shell version in Travis CI #1471
[Tests] Print all shell version in Travis CI #1471
Conversation
@@ -23,6 +23,9 @@ before_install: | |||
- $SHELL --version 2> /dev/null || dpkg -s $SHELL 2> /dev/null || which $SHELL | |||
- curl --version | |||
- wget --version | |||
- bash --version | head | |||
- zsh --version | |||
- dpkg -s dash | grep ^Version | awk '{print $2}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aren't these covered by line 23?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, forgot to delete it, I wonder if we could directly print the versions instead of dynamic call the shell? Just like we print both wget
and curl
versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't line 23 what dynamically prints the versions already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I mean not to dynamic print them but directly print them all.
25725b3
to
7bbc573
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if tests pass, why not
No description provided.