Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Print all shell version in Travis CI #1471

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

PeterDaveHello
Copy link
Collaborator

No description provided.

@@ -23,6 +23,9 @@ before_install:
- $SHELL --version 2> /dev/null || dpkg -s $SHELL 2> /dev/null || which $SHELL
- curl --version
- wget --version
- bash --version | head
- zsh --version
- dpkg -s dash | grep ^Version | awk '{print $2}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't these covered by line 23?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, forgot to delete it, I wonder if we could directly print the versions instead of dynamic call the shell? Just like we print both wget and curl versions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't line 23 what dynamically prints the versions already?

Copy link
Collaborator Author

@PeterDaveHello PeterDaveHello Apr 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I mean not to dynamic print them but directly print them all.

@ljharb ljharb added the testing Stuff related to testing nvm itself. label Apr 2, 2017
@PeterDaveHello PeterDaveHello changed the title [Tests] Print shell version in Travis CI [Tests] Print all shell version in Travis CI Apr 2, 2017
@ljharb ljharb force-pushed the travis-ci-print-shell-version branch from 25725b3 to 7bbc573 Compare September 29, 2021 05:57
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if tests pass, why not

@ljharb ljharb merged commit 7bbc573 into nvm-sh:master Sep 29, 2021
@PeterDaveHello PeterDaveHello deleted the travis-ci-print-shell-version branch September 29, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Stuff related to testing nvm itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants