Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marine areas: Seto Inland Sea (Japan) labeled as Scottish Inner Seas #665

Closed
pbregener opened this issue Jan 7, 2022 · 3 comments
Closed

Marine areas: Seto Inland Sea (Japan) labeled as Scottish Inner Seas #665

pbregener opened this issue Jan 7, 2022 · 3 comments
Milestone
v5.1.0

Comments

@pbregener
Copy link

pbregener commented Jan 7, 2022 •
edited
Loading

The Seto Inland Sea (Q231312) is labeled incorrectly as Inner Seas off the West Coast of Scotland (Q5762423):
image
@pbregener pbregener changed the title Marine areas: Japanese inland sea labeled as Scottish inner sea Marine areas: Seto Inland Sea (Japan) labeled as Scottish Inner Seas Jan 7, 2022
@nvkelso
Copy link
Owner

nvkelso commented Jan 7, 2022

Whoops, good catch!

Let's also look at Korea Straight which is in your screenshot but without a clear polygon associated with it.

@nvkelso nvkelso added this to the v5.1.0 milestone Jan 7, 2022
@nvkelso nvkelso mentioned this issue Mar 31, 2022
Closed
@nvkelso
Copy link
Owner

nvkelso commented Mar 31, 2022

cc @mits003 and @Kanahiro who participated in discussion in #703.

Related work in #697 which tracks both missing gulf between Iceland and Greenland, and proposal for grouping marine areas into ocean basins.

@nvkelso nvkelso mentioned this issue Apr 14, 2022
Closed
nvkelso added a commit that referenced this issue Apr 14, 2022
@nvkelso
East Sea / Sea of Japan; Persian Gulf / Arabian Gulf; Japanese Inner …
dceac1e 
…Sea #665; Korean Straight #712
@nvkelso nvkelso modified the milestones: v5.1.0, v5.0.2 Apr 14, 2022
@nvkelso nvkelso mentioned this issue Apr 14, 2022
Merged
@nvkelso
Copy link
Owner

nvkelso commented May 5, 2022

Fixed via #713.

@nvkelso nvkelso closed this as completed May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.1.0
Development

No branches or pull requests
2 participants
@nvkelso @pbregener