-
-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(git): git_commits shows the current branch graph #2288
Conversation
I gave it quick test. It showed a bit of graph on telescope. However, tags/HEAD no longer showing on the commits. Could you please make it optional change. Thanks btw: #1041 example is amazing. Wish if this can be produced or configured here. The date thing is pretty useful |
Ops. Sorry for that mistake, and the new commit added the tags/HEAD. the #1041 example is pretty cool, and I am trying to add colours to get a nicer display. Cheers 🍻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Indeed I can see the tags/HEAD now.
Please fix the CI failing actions so we can merge.
Any additional enhancement can be done in another pr (tag me)
msg = "" | ||
end | ||
|
||
if not msg then | ||
sha = entry | ||
msg = "<empty commit message>" | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't not msg
be always false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the check makes sense. its nil (and we enter this branch) if we match a line that has no commit message (its nil because of string.match) but its and empty string if we dont even have a sha, so we do not enter this branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
LGTM
@kkharji feel free to merge, if your last comment is resolved and sorry about the broken CI, i merged something styled wrong into master a week ago and was to lazy to resolve it ^^
Edit: I just rebased the branch, you are still author of the commits :)
This should be optional. It breaks custom Also, the help documentation isn't updated and it was pretty confusing. |
@kkharji @CyanJoeng for some reason when using Also @SebTalbot is right, documentations need a revamp. |
There is a proposed solution in #2357 which makes things even worse (see #2357 (comment)), so i decided to revert. sorry for the inconvenience, i should have caught and this should have never been merged |
This reverts commit 01d9228.
Description
I'd like to see a graph view in git_commits picker, and notice the closed issue (#1041) when I try to find some solutions.
I'm not familiar with the Lua language, so, a little modifications are written to achieve the basic demand.
Feat # (#1041)
show the current branch graph when viewing git_commits
Type of change
How Has This Been Tested?
Invoking the git picker function builtin.git_commits by a vim key mapping, the the commits log with graph will displayed in the popup window.
NB. commit logs showing with graph will insert extra entries with no SHA value, so a error msg will shown in the vim msg bar if these extra entries selected.