Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow results in async_oneshot_finder #1461

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

fdschmidt93
Copy link
Member

The use case for this in telescope-file-browser is prepending the current directory in the folder browser when using fd, since fd of course blocks a lot less than scan dir in large repos.

The canonical shell equivalent of that would be echo "." && fd -t d` (see also sharkdp/fd#364) but I don't think plenary Jobs supports that.

I guess it's a bit of an edge case and I honestly couldn't think of other good uses. At the same time it should be pretty harmless because finders yells if results are passed, so you'd have to user the lower level api anyways.

@Conni2461
Copy link
Member

We no longer do plenary jobs in finders (we have some piping support with after_success in plenary jobs tho). We now use _.luas LinePipe implementation

I think we can do this, so i merge this. But you can also think about a custom finder that works with scan_dir_async. It can stream in data so this should work almost as good as fd and oneshot. (I know about your timing situation right now, so this is just a suggestion).

@Conni2461 Conni2461 merged commit 9d7d322 into nvim-telescope:master Dec 3, 2021
razak17 pushed a commit to razak17/telescope.nvim that referenced this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants