Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: introduce rocks.troubleshooting + UX tweaks #435

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

teto
Copy link
Member

@teto teto commented Jun 28, 2024

Looking at #424, I think we can better guide the user in case of error, instead of displaying Could not find diffview.nvim. Search for 'dev' version? y/n: , we could show a vim.ui.select:

  1. Install the "dev" version (when we know it exists)
  2. Install via rocks-git (and install rocks-git if not available)
    < mention rocks.troubleshootingi or an url towards how to add plugins to luarocks / link to luarocks packaging requests #111 >

Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

@mrcjkb
Copy link
Member

mrcjkb commented Jun 28, 2024

Install via rocks-git (and install rocks-git if not available)

I think it's fine just to mention the possibility of using rocks-git in the docs.
rocks.nvim shouldn't be "aware" of any external modules and there's no way to infer the repo owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants