refactor: use new icons for done/undone as per nerd fonts 3.0
#849
Conversation
|
Oh dang, thanks for making us aware of this. I wonder - how long will it take before this change propagates to everyone? I'm not sure how fast the release cycle is for fonts in various package managers, moreso when you start talking about other operating systems like Mac or Windows. I'm afraid that merging this right away will cause some long term confusion, so perhaps we should wait a few days before the merge? |
obreitwi
force-pushed
the
fix/codepoints/task_conceal
branch
from
30cd6ab to
5c880d8
Compare
|
Yeah, I would suspect the change will take a while to propagate. For example, the font I use was patched earlier only earlier this week. Is there an FAQ or trouble shooting guide it could be added to? Or a compatibility setting that could be used to switch the used icon… Afaik, there is no way to check if a code point is present in the font currently used by the terminal, so it will require user action… :/ |
obreitwi
force-pushed
the
fix/codepoints/task_conceal
branch
2 times, most recently
from
b7269fb to
7be8712
Compare
The icons used to conceal 'done' and 'pending' tasks were [moved to new code points](https://github.com/ryanoasis/nerd-fonts/blob/master/changelog.md#breaking-2-material-design-icons-codepoints). This commit fixes them according to [this translation table](ryanoasis/nerd-fonts#1059 (comment)).
obreitwi
force-pushed
the
fix/codepoints/task_conceal
branch
from
7be8712 to
43ce246
Compare
|
I see quite a lot of other projects adapt to nerd fonts 3.0 so I guess it's our time to do so now too! Thanks for the PR :) |
vhyrro
changed the title
done/undone as per nerd fonts 3.0
The icons used to conceal 'done' and 'pending' tasks were moved to new code points. This commit fixes them according to this translation table.