Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toc): improve toc #1221

Merged
merged 8 commits into from
Dec 26, 2023
Merged

Conversation

champignoom
Copy link
Contributor

@champignoom champignoom commented Dec 13, 2023

  1. Sync cursor upon creating toc (resolves feat(toc): add config for enabling synchronized cursorline in toc window #1198 (comment))
  2. When previewing from toc, keep the previewed heading in screen center (like scrolloff=999)
  3. enable folding so that one can zc and zo on toc items
  4. ToC per tabpage instead of per nvim session
  5. display todo status (resolves TODO indicators in TOC #1237)
  6. :Neorg toc updates ToC instead of throwing errors when ToC exists

@champignoom
Copy link
Contributor Author

image

I don't understand.

@pysan3
Copy link
Contributor

pysan3 commented Dec 13, 2023

They have to merge this PR or all PRs will be broken
#1209

@pysan3
Copy link
Contributor

pysan3 commented Dec 13, 2023

It is running the linting against the target branch (i.e. the current neorg's main branch), and as it is broken now, all PRs will result in a ❌

@champignoom champignoom changed the title feat(toc): improve sync_cursorline feat(toc): improve toc Dec 13, 2023
@champignoom champignoom mentioned this pull request Dec 21, 2023
1 task
@vhyrro
Copy link
Member

vhyrro commented Dec 26, 2023

Thank you so much for the work! I'll try to resolve all of the failing checks after merging the PRs.

@vhyrro vhyrro merged commit 0171df1 into nvim-neorg:main Dec 26, 2023
0 of 2 checks passed
@pysan3
Copy link
Contributor

pysan3 commented Dec 26, 2023

@vhyrro I don't know if this is the right place to put this but...

image

@pysan3
Copy link
Contributor

pysan3 commented Dec 26, 2023

And
image

I guess there's more errors not detected. I feel there are some variables that are defined without a local.

@vhyrro
Copy link
Member

vhyrro commented Dec 26, 2023

hah, your fix should prevent stuff like this in the future. As I said after merging all of these PRs I'll just fix the errors manually :)

@pysan3
Copy link
Contributor

pysan3 commented Dec 26, 2023

Thanks @vhyrro ;)

@pysan3
Copy link
Contributor

pysan3 commented Dec 26, 2023

Also @vhyrro , over on Discord #neorg-dev ,

max397 — 2023/12/04 15:48
can we just make the typecheck a requirement to be able to merge?

pysan3 — 2023/12/05 02:09
This should fix it? #1209

max397 — 2023/12/05 02:10
well idk if this was an issue
but what I'm talking about it that mergin should be completely blocked unless these checks pass

pysan3 — 2023/12/05 02:12
That is a repository option @vhyrro https://stackoverflow.com/questions/58654530/how-to-auto-reject-a-pull-request-if-tests-are-failing-github-actions
(Idk who else has the permission)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TODO indicators in TOC
3 participants