feat: (wip) Redesigned event publishing system #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhyrro
reviewed
Sep 10, 2023
Comment on lines
+86
to
+92
| cursor_position = vim.api.nvim_win_get_cursor(0), | ||
| filename = fn.expand("%:t"), | ||
| filehead = fn.expand("%:p:h"), | ||
| line_content = api.nvim_get_current_line(), | ||
| buffer = api.nvim_get_current_buf(), | ||
| window = api.nvim_get_current_win(), | ||
| mode = api.nvim_get_mode().mode, |
There was a problem hiding this comment.
Am happy to deprecate these! These used to be required when events were sent via vim.schedule, in which case you could get outdated information about the current buffer ID etc.
vhyrro
reviewed
Sep 10, 2023
|
|
||
|
|
||
| ---@alias neorg.event.neorg_started nil | ||
| ---Informs that Neorg has finished loaded. Its payload is empty. |
There was a problem hiding this comment.
Tiny typo - "has finished loaded" -> "has finished loading" :)
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Groctel
commented
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the #999 project, this is a WIP PR just so you can see how I'm working on the events system and offer your suggestions and criticism. Check
neorg.core.eventsfor an in-depth explanation on how the events system is designed.