Skip to content

Conversation

@pysan3
Copy link
Collaborator

@pysan3 pysan3 commented Jun 25, 2023

Came from the discussion #1006.

TODOs

  • Please check if # Your Configuration section template is OK for you.

Mentions

@miversen33 @cseickel @nhat-vo

@cseickel
Copy link
Contributor

This is fine by me, but I'd like to hear @miversen33's thought since it was his idea.

@miversen33
Copy link
Collaborator

@pysan3 added a quick comment to the PR.

I tested the repro config on a windows machine just to verify that it works on there as well (lots of people in the neovim community assume linux so I wanted to cover our bases). It does indeed work on windows as well so that's awesome.

Thanks for getting this together!

@pysan3
Copy link
Collaborator Author

pysan3 commented Jun 25, 2023

The config part is mostly done by folke and I just added local neotree_config = ... so big thanks to him ;)

@pysan3
Copy link
Collaborator Author

pysan3 commented Jun 25, 2023

Anyways, thanks for your feedbacks and I think it's safe to merge this PR and have a way better debugging experience for us @cseickel !!

@cseickel cseickel merged commit 7e01131 into nvim-neo-tree:main Jun 25, 2023
@miversen33
Copy link
Collaborator

Lol so uhh, we aren't making the repro configuration required?

@cseickel
Copy link
Contributor

@pysan3 added a quick comment to the PR.

Lol so uhh, we #1013 (comment)?

Did you forget to submit a pending review?

@miversen33
Copy link
Collaborator

My comment is listed as pending. I wonder if since I'm not marked as required or something, GitHub didn't make my pending review prevent the merge? Idk, just spit balling

@cseickel
Copy link
Contributor

Pending means "draft", only you can see it. You have to submit the pending review for anyone else to see your comments.

@miversen33
Copy link
Collaborator

Pending means "draft", only you can see it. You have to submit the pending review for anyone else to see your comments.

Huh check that out. I thought simply commenting on the code snippet was good enough, but it seems that you have to push your review through. Good catch @cseickel :)

@pysan3
Copy link
Collaborator Author

pysan3 commented Jul 5, 2023

Lol I did the exact same thing just a few days ago: #1004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants