-
Notifications
You must be signed in to change notification settings - Fork 272
feat(issue): add bug_report, feature_request issue template
#1013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is fine by me, but I'd like to hear @miversen33's thought since it was his idea. |
|
@pysan3 added a quick comment to the PR. I tested the repro config on a windows machine just to verify that it works on there as well (lots of people in the neovim community assume linux so I wanted to cover our bases). It does indeed work on windows as well so that's awesome. Thanks for getting this together! |
|
The config part is mostly done by folke and I just added |
|
Anyways, thanks for your feedbacks and I think it's safe to merge this PR and have a way better debugging experience for us @cseickel !! |
|
Lol so uhh, we aren't making the repro configuration required? |
Did you forget to submit a pending review? |
|
My comment is listed as pending. I wonder if since I'm not marked as required or something, GitHub didn't make my pending review prevent the merge? Idk, just spit balling |
|
Pending means "draft", only you can see it. You have to submit the pending review for anyone else to see your comments. |
Huh check that out. I thought simply commenting on the code snippet was good enough, but it seems that you have to push your review through. Good catch @cseickel :) |
|
Lol I did the exact same thing just a few days ago: #1004 |
Came from the discussion #1006.
TODOs
# Your Configurationsection template is OK for you.Mentions
@miversen33 @cseickel @nhat-vo