Updated the performance metric (translation/sec) #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will be good to get this into release/2.17.0 to represent NMT performance numbers correctly |
rmittal-github
approved these changes
Sep 18, 2024
virajkarandikar
approved these changes
Sep 18, 2024
rmittal-github
added a commit
that referenced
this pull request
Sep 30, 2024
* Add DNT (do not translate) support in S2S and S2T clients (#91) * Add list_models option for s2s/s2t clients (#93) * Support custom_configuration param for ASR clients (#92) * Adding AST support for offline client * Updating cli keywords * exposing custom_configuration to cli * Code formatting * Throwing expection for invalid custom configurations * Updating help message * Updating client test * Trim unwanted whitespaces while reading phrases file (#97) * Add list_models option for ASR clients (#94) * Update NMT text client to report tokens/sec (#90) * performance metric-translation/sec updated * performance metric-translations/sec updated * Update riva_nmt_t2t_client.cc * Update riva_nmt_t2t_client.cc * updated perf metric and new line added * updated perf metric and new line deleted * Update riva_nmt_t2t_client.cc * Update riva_nmt_t2t_client.cc * Update riva_nmt_t2t_client.cc * Update riva_nmt_t2t_client.cc * Update riva_nmt_t2t_client.cc * Update riva_nmt_t2t_client.cc * Update riva_nmt_t2t_client.cc * Update riva_nmt_t2t_client.cc * Update riva_nmt_t2t_client.cc --------- Co-authored-by: Yuvaraj Dharavath <[email protected]> * Support to set max speakers for offline diarization (#98) * fix: accept input for max_speaker_count in riva_asr_client * update: default max_speaker_count to 3 * fix: rename input field to diarization_max_speakers * fix: var name for consistency * Fix output file dump for S2T client (#99) * updated * performance metric-translations/sec updated * updated t2t client * updated perf metric and new line added * Update streaming_s2t_client.cc * Update streaming_s2t_client.h * riva streaming s2t client updated * updated t2t client * streaming s2t client updated * Update streaming_s2t_client.h * Update riva_nmt_streaming_s2t_client.cc * Update riva_nmt_streaming_s2t_client.cc * Update riva_nmt_t2t_client.cc * Update streaming_s2t_client.cc * Update streaming_s2t_client.h * Update client_call.h * Update streaming_s2t_client.cc * updated streaming s2t client * unwanted changes removed * extra line removed * extra line removed * updated t2t client * updated * streaming_s2t_client updated * s2t client audio procesed updated * extra lines removed --------- Co-authored-by: Manisha Johnson <[email protected]> Co-authored-by: Yuvaraj Dharavath <[email protected]> * update SHA of common repo --------- Co-authored-by: shiralal <[email protected]> Co-authored-by: sarane22 <[email protected]> Co-authored-by: ydharavath <[email protected]> Co-authored-by: Yuvaraj Dharavath <[email protected]> Co-authored-by: Prabhsimran Singh <[email protected]> Co-authored-by: Manisha Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the translation/sec metric displayed the number of sentences translated per second but now the tranlsation/sec metric is modified to show number of tokens translated/sec.