-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposing the 'stop_historu_eou_th' parameter #83
Merged
rmittal-github
merged 11 commits into
nvidia-riva:release/2.16.0
from
sarane22:endpointing_stop_eou_threshold_param
Jun 27, 2024
Merged
Exposing the 'stop_historu_eou_th' parameter #83
rmittal-github
merged 11 commits into
nvidia-riva:release/2.16.0
from
sarane22:endpointing_stop_eou_threshold_param
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Update the |
LGTM, will merge once proto change is merged and server pipeline is ok |
rmittal-github
approved these changes
Jun 27, 2024
rmittal-github
pushed a commit
that referenced
this pull request
Jul 3, 2024
* Exposing the 'stop_historu_eou_th' parameter * Updating constructor * Updating constructor * Adding verbose logs for 2-pass end of utterance * Removing --verbose parameter * Updating param name * Updating help for VAD param * Adding check for stop_threshold_eou_ * minor change * Adding VLOG * Updating proto to release/24.06 commit
rmittal-github
added a commit
that referenced
this pull request
Jul 3, 2024
* Exposing the 'stop_historu_eou_th' parameter * Updating constructor * Updating constructor * Adding verbose logs for 2-pass end of utterance * Removing --verbose parameter * Updating param name * Updating help for VAD param * Adding check for stop_threshold_eou_ * minor change * Adding VLOG * Updating proto to release/24.06 commit Co-authored-by: sarane22 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, clients can now configure
stop_eou_threshold
for streaming ASR:The new parameters introduced are:
--stop_eou_threshold = float