-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TTS: Add user dictionary parameter to tts-client #80
Merged
rmittal-github
merged 9 commits into
nvidia-riva:main
from
manishaj-nv:dev/mkj/tts_add_custom_g2p
Aug 7, 2024
Merged
TTS: Add user dictionary parameter to tts-client #80
rmittal-github
merged 9 commits into
nvidia-riva:main
from
manishaj-nv:dev/mkj/tts_add_custom_g2p
Aug 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@manishaj-nv let's also push a python-clients MR |
@mohnishparmar as well for review |
@manishaj-nv could you please resolve the open comments? also, need to update the latest proto SHA here and test the latest commit with CI |
rmittal-github
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, need to test with CI
377678f
to
2b28c05
Compare
171c072
to
97ec7ac
Compare
rmittal-github
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a addition of custom grapheme-to-phoneme dictionary for the Riva TTS client. The custom dictionary takes precedence over the default grapheme-to-phoneme rules and if a word is present in both the custom dictionary and the default rules, the custom mapping will be used.
Ensure custom handling of the dictionary is handled in the client end and is of the format key.
Read textFile and pass as string of the format to the API "ARON ˈdʒɑnsən,AARON ˈdʒɑnsən"
Usage
To use, pass the --user_dictionary flag with the path to your dictionary file when running the riva_tts_client
Example:
riva_tts_client --voice_name=English-US.Female-1 --text=" Hi Aaron, this is speech synthesizer" --audio_file=/opt/riva/riva-speech/output.wav --user_dictionary=<valid_dictionary_path>