fix lora initialization problem. Original method leads lora-A initialization all zeros --> No training #15
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ization all zeros --> No training Signed-off-by: annaJ2178 <[email protected]>
| net.init_weights() | ||
|
|
||
| if config.use_lora: | ||
| self.add_lora( |
There was a problem hiding this comment.
Thank you for pointing it out, I agree adding loRA after weights initialization is better to preserve (random A, zero B) metrices. We will add the change in the code.
|
@pjannaty please feel free to close this issue. It has been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original initialization method (add lora before init_weight) leads lora_A initialization all zeros. Add lora after init_weights can fix that