Skip to content

[Toggle Device] Can't drag a sound device #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0xEBO opened this issue Jun 18, 2022 · 5 comments
Closed

[Toggle Device] Can't drag a sound device #2

0xEBO opened this issue Jun 18, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@0xEBO
Copy link

0xEBO commented Jun 18, 2022

Hi!

I'm unable to drag and drop or double clic a sound device in the "Toggle Device" section.
image

My use of this feature is to switch between Speakers and Headset on a single Knob press.

Thanks for your hard work!

@nvdweem nvdweem added the bug Something isn't working label Jun 18, 2022
@nvdweem
Copy link
Owner

nvdweem commented Jun 18, 2022

This should now be fixed. The 1.4-SNAPSHOT installer should be updated already.

@0xEBO
Copy link
Author

0xEBO commented Jun 18, 2022

Drag and drop is now working 👍🏻, but the actual action of switching between devices doesn't work on knob clic.

Here is the message I get in the log file :
2022-06-18 21:49:41.099 ERROR 3236 --- [Command Handler Thread] c.g.c.c.CommandVolumeDefaultDeviceToggle : TODO

I guess it has to do with this :

@nvdweem
Copy link
Owner

nvdweem commented Jun 18, 2022

I probably should have actually tested. The functionality instead of just the drag and drop :)
I'll look into fixing the Todo tomorrow. Might be a good moment to check if I put more todos in the code ;)

@nvdweem
Copy link
Owner

nvdweem commented Jun 19, 2022

The todo should now be implemented. I've tried to make it a bit smarter than just having a fixed order. If you manually change the output device (or do so through another button action) the order will continue from the current default device.

I also changed the UI a bit. I don't think it makes sense to combine input and output devices in the list so the list disables the output devices if you select an input device and the other way around. If this assumption is wrong please let me know because it will also mean that following the current default device can't be done because there would be multiple default devices :).

@0xEBO
Copy link
Author

0xEBO commented Jun 19, 2022

It works perfectly well, thanks a lot! 🥇

@0xEBO 0xEBO closed this as completed Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants