Skip to content

Commit

Permalink
sql: don't remove batch limit in local lookup join
Browse files Browse the repository at this point in the history
Previously, the local lookup join node was created with an underlying
scan with an explicitly disabled batch limit. This is the wrong thing to
do, since that scan will be used as a full table scan - it needs a batch
limit to prevent OOM errors.

Release note: None
  • Loading branch information
jordanlewis committed Aug 30, 2018
1 parent f7b5ab6 commit 9dd868c
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pkg/sql/opt_exec_factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,6 @@ func (ef *execFactory) ConstructLookupJoin(

tableScan.index = indexDesc
tableScan.run.isSecondaryIndex = (indexDesc != &tabDesc.PrimaryIndex)
tableScan.disableBatchLimit()

n := &lookupJoinNode{
input: input.(planNode),
Expand Down

0 comments on commit 9dd868c

Please sign in to comment.