Restore VoiceSettingsSlider to ensure we don't break compatibility with Audio Themes add-on

[LeonarddeR]

Link to issue number:

Fixes #9824

Summary of the issue:

#8214 moved settingsDialogs.VoiceSettingsSlider and didn't handle backwards compatibility correctly.

Description of how this pull request fixes the issue:

Restore VoiceSettingsSlider, log a deprecation warning when it is initialized.

Testing performed:

• Tested that audio themes add-on works again.
• Made sure that the warning about VoiceSettingSlider uses the proper stack level.

Known issues with pull request:

The NVDA log is full of warnings when Audio Themes is used. I think that Audio Themes should no longer be listed at the NVDA add-ons website as a stable add-on until proper maintenance has taken place. Cc @josephsl

Change log entry:

None

[LeonarddeR]

Note that this pr should be reverted from threshold as soon as beta is merged into master and master into threshold.

[Brian1Gaff]

I think personally that a warning on the add on should be sufficient as there will be a whole host of add ons needing work when python 3 comes along but there is no need to worry users now, as it is easily sorted in this case. Maybe somebody needs to get together with the add on team and decide how to proceed when the new Python 3 version comes out, otherwise a lot of people are suddenly going to find more important add ons they rely on, even in work might just be disabled and no longer work with no idea if they are going to be fixed. This will break up NVDA users to those stuck on the old version with working add ons, and those on Python 3 version, with non working add ons. Just saying with an eye on reliability and reputation of nvda. Brian bglists@blueyonder.co.uk Sent via blueyonder. Please address personal E-mail to:- briang1@blueyonder.co.uk, putting 'Brian Gaff' in the display name field. Newsgroup monitored: alt.comp.blind-users ----- Original Message ----- From: "Leonard de Ruijter" <notifications@github.com> To: "nvaccess/nvda" <nvda@noreply.github.com> Cc: "Subscribed" <subscribed@noreply.github.com> Sent: Thursday, June 27, 2019 6:10 AM Subject: [nvaccess/nvda] Restore VoiceSettingsSlider to ensure we don't break compatibility with Audio Themes add-on (#9826)

…

### Link to issue number: Fixes #9824 ### Summary of the issue: #8214 moved settingsDialogs.VoiceSettingsSlider and didn't handle backwards compatibility correctly. ### Description of how this pull request fixes the issue: Restore VoiceSettingsSlider, log a deprecation warning when it is initialized. ### Testing performed: Tested that audio themes add-on works again. ### Known issues with pull request: The NVDA log is full of warnings when Audio Themes is used. I think that Audio Themes should no longer be listed at the NVDA add-ons website as a stable add-on until proper maintenance has taken place. Cc @josephsl ### Change log entry: None You can view, comment on, or merge this pull request online at: #9826 -- Commit Summary -- * Restore VoiceSettingsSlider to ensure we don't break compatibility with Audio Themes add-on -- File Changes -- M source/gui/settingsDialogs.py (9) -- Patch Links -- https://github.com/nvaccess/nvda/pull/9826.patch https://github.com/nvaccess/nvda/pull/9826.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #9826

[Brian1Gaff]

What about Alpha? I assume this will stay as it will become beta eventually? Brian bglists@blueyonder.co.uk Sent via blueyonder. Please address personal E-mail to:- briang1@blueyonder.co.uk, putting 'Brian Gaff' in the display name field. Newsgroup monitored: alt.comp.blind-users -----

[josephsl]

Hi, I have notified add-ons community so we can take appropriate action. I expect a decision will be made within the next 24 hours. Thanks. From: Leonard de Ruijter <notifications@github.com> Sent: Wednesday, June 26, 2019 10:10 PM To: nvaccess/nvda <nvda@noreply.github.com> Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com> Subject: [nvaccess/nvda] Restore VoiceSettingsSlider to ensure we don't break compatibility with Audio Themes add-on (#9826) Link to issue number: Fixes #9824 <#9824> Summary of the issue: #8214 <#8214> moved settingsDialogs.VoiceSettingsSlider and didn't handle backwards compatibility correctly. Description of how this pull request fixes the issue: Restore VoiceSettingsSlider, log a deprecation warning when it is initialized. Testing performed: Tested that audio themes add-on works again. Known issues with pull request: The NVDA log is full of warnings when Audio Themes is used. I think that Audio Themes should no longer be listed at the NVDA add-ons website as a stable add-on until proper maintenance has taken place. Cc @josephsl <https://github.com/josephsl> Change log entry: None

…

_____ You can view, comment on, or merge this pull request online at: #9826 Commit Summary * Restore VoiceSettingsSlider to ensure we don't break compatibility with Audio Themes add-on File Changes * M source/gui/settingsDialogs.py <https://github.com/nvaccess/nvda/pull/9826/files#diff-0> (9) Patch Links: * https://github.com/nvaccess/nvda/pull/9826.patch * https://github.com/nvaccess/nvda/pull/9826.diff — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9826?email_source=notifications&email_token=AB4AXEFRARQIHNWNI67OKKTP4RDTXA5CNFSM4H3YFNRKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G37EQBQ> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AB4AXEAYR33K2OCKWKXGQHTP4RDTXANCNFSM4H3YFNRA> .

[Brian1Gaff]

Confirm current alpha and beta snaps now give no errors from add ones. Obviously beta 2 is still the old build. Brian bglists@blueyonder.co.uk Sent via blueyonder. Please address personal E-mail to:- briang1@blueyonder.co.uk, putting 'Brian Gaff' in the display name field. Newsgroup monitored: alt.comp.blind-users ----- Original Message ----- From: "Michael Curran" <notifications@github.com> To: "nvaccess/nvda" <nvda@noreply.github.com> Cc: "Brian Gaff" <bglists@blueyonder.co.uk>; "Comment" <comment@noreply.github.com> Sent: Thursday, June 27, 2019 11:22 PM Subject: Re: [nvaccess/nvda] Restore VoiceSettingsSlider to ensure we don't break compatibility with Audio Themes add-on (#9826)

…

Merged #9826 into beta. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #9826 (comment)

[DrSooom]

@LeonarddeR: Issue #9824 and this PR have each the wrong milestone (2019.3 instead of 2019.2).