Skip to content

App module handler/does app mod exists: return false when called before imports are initialized #9800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelDCurran merged 2 commits into from
Jun 25, 2019
Merged

App module handler/does app mod exists: return false when called before imports are initialized #9800

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da811c0
App module handler/does app mod exists: catch attribute error and ass…
josephsl Jun 24, 2019
b94925b
App module handler/review actions: return early if importers list is …
josephsl Jun 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion source/appModuleHandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,11 @@ def cleanup():
log.exception("Error terminating app module %r" % deadMod)

def doesAppModuleExist(name):
return any(importer.find_module("appModules.%s" % name) for importer in _importers)
# #9797: when invoked from system tests, importers list isn't initialized (attribute error on a None object), thus assume no app module exists.
try:

@michaelDCurran michaelDCurran Jun 24, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer just to check if _importers is None and return False, rather than letting it knowingly fail.
Though I'd like to also understand why systemTestSpy actually causes doesAppModule exist to be called? can you provide an example traceback on the issue?

return any(importer.find_module("appModules.%s" % name) for importer in _importers)
except AttributeError:
return False

def fetchAppModule(processID,appName):
"""Returns an appModule found in the appModules directory, for the given application name.
Expand Down