Skip to content

Ensure NVDA contains a signed and valid python37.dll #9796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelDCurran merged 2 commits into from
Jun 24, 2019
Merged

Ensure NVDA contains a signed and valid python37.dll #9796

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c05c816
sconstruct: after running py2exe, copy a fresh version of python37.dl…
michaelDCurran Jun 24, 2019
7517cbd
Sconstruct: Fix typo in comment.
michaelDCurran Jun 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sconstruct
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import os
import time
from glob import glob
import sourceEnv
from py2exe.dllfinder import pydll
import importlib.util

def recursiveCopy(env,targetDir,sourceDir):
Expand Down Expand Up @@ -262,6 +263,11 @@ def NVDADistGenerator(target, source, env, for_signature):

action.append(buildCmd)

# Python3 has started signing its main python dll.
# However, Py2exe currently tries to add a string resource to it, invalidating the signature and possibly currupting the certificate.
# Therefore, copy a fresh version of the dll one more time once py2exe has completed.
action.append(Copy(target[0],pydll))

if certFile:
for prog in "nvda_noUIAccess.exe", "nvda_uiAccess.exe", "nvda_slave.exe", "nvda_eoaProxy.exe":
action.append(lambda target,source,env, progByVal=prog: signExec([target[0].File(progByVal)],source,env))
Expand Down