Repository navigation
Python 3: zip function -> list(zip), itertools.izip -> zip() #9729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
michaelDCurran
merged 5 commits into
nvaccess:threshold_py3_staging
from
josephsl:py3izip2zip
Jun 14, 2019
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
16760df
Language list/Python 3: wrap zip function call inside a list call.
josephsl cac359e
IAccessible/IA2mozilla: itertools.izip -> zip, remove itertools import.
josephsl 7f211c8
Braille: itertools.izip -> zip function.
josephsl c1cebc7
Language handler: remove extraneous whitespace
josephsl 440da53
Izip to zip (address review actions): simplify comment in language ha…
josephsl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -108,7 +108,9 @@ def getAvailableLanguages(presentational=False): | |
| displayNames.append("%s, %s"%(desc,entry) if desc else entry) | ||
| #Prepare a zipped view of language codes and descriptions. | ||
| # #7284: especially for sorting by description. | ||
| langs = zip(locales,displayNames) | ||
| # #7105 (Py3 review required): Python 2 list 0> Python 3 iterator. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this comment is necessary. Furthermore, it contains a typo. |
||
| # Thus wrap this inside a list call. | ||
| langs = list(zip(locales,displayNames)) | ||
| if presentational: | ||
| langs.sort(key=lambda lang: lang[1]) | ||
| #include a 'user default, windows' language, which just represents the default language for this user account | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split this line while at it