Minor Remote Server Fixes - #17808
Merged
Merged
Conversation
Fix socket.listen() call by removing keyword argument. Changed from `listen(backlog=5)` to `listen(5)` as socket methods use positional-only parameters per PEP 570.
SaschaCowley
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Minor fixes to previous PR #17580
Summary of the issue:
This PR addresses inconsistencies in the
LocalRelayServerclass in the remote client server implementation. There were variable naming discrepancies and an incorrect method parameter format that needed to be fixed.Description of user facing changes
No user-facing changes. These are purely internal code consistency fixes.
Description of development approach
The changes correct three minor issues:
PING_TIMEtoPING_TIME_SECONDSto match the actual variable namePING_TIMEin the code to use the correct variable namePING_TIME_SECONDSlisten()method call to use positional arguments instead of keyword arguments for better backward compatibilityTesting strategy:
Verified that the remote client server still functions correctly with these changes. The server successfully:
Known issues with pull request:
None