-
-
Notifications
You must be signed in to change notification settings - Fork 820
Remote Access #17580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remote Access #17580
Changes from all commits
Commits
Show all changes
207 commits
Select commit
Hold shift + click to select a range
e483ed1
Add NVDA Remote functionality to core NVDA
ctoth 3d38ad2
Fix failed certificate callback
ctoth e0a8946
refactor: simplify remote speech handling using extension points
ctoth 4b7eac9
Warn, not error for unknown message types
ctoth 927d4f1
refactor: remove NVDA patcher system and integrate braille handling d…
ctoth 77366a0
Remove unused `CallbackManager` and patcher modules
ctoth 258106d
Improve logic for callback registration
ctoth ced7345
fix: prevent duplicate callback registration and improve callback lif…
ctoth afa53b3
Improve logging
ctoth 1378815
Add missing @alwaysCallAfter decorators
ctoth 1820d93
Fix braille input
ctoth 7ac87d3
feat(remoteClient): add TypedDict for PortCheckResponse
ctoth 542c174
Fix translator note comment
ctoth aaa5428
refactor: migrate remote config to use main config system (#350)
ctoth d8cb51c
refactor: Remote Client: Ensure consistent feedback for deafblind users
ctoth 8f6cf6f
Naming and typing fixes
ctoth 2aaa3ea
Add `pre_speechQueued` to the table of extension points and export it…
ctoth 1d26a7e
docs: add remote access documentation to user guide
ctoth d7ed00e
feat(remoteClient): make RemoteMenu conditional on secure desktop status
ctoth a230d8a
feat: block remote connection actions in secure mode and rename for c…
ctoth 14c208f
Use playWaveFile directly for remote sounds
ctoth 3147cf8
Fix secure desktop check
ctoth 2f474ef
Don't write config after receiving MOTD
ctoth 14468e3
Add .wav suffix to cues
ctoth c9a0a38
Better handle wave files
ctoth 1541727
Added Remote Certificate Manager to self-sign certificates for the bu…
ctoth 0a62d5d
Add cryptography dependency to requirements.txt
ctoth 3cc3c42
Hidden import of CFFI to satisfy py2exe per pyca/cryptography#5122
ctoth d0ee2bb
security: Improve certificate handling for self-hosted remote connect…
ctoth aa2f6e5
fix: Update SSL socket configuration and connection settings
ctoth ed1fba9
fix: Change localhost binding from IP to hostname in secure desktop r…
ctoth a1cc380
feat: Add comprehensive logging to SecureDesktopHandler module
ctoth 94e12e4
feat: Add comprehensive logging to server module for improved monitor…
ctoth f40eade
refactor: Replace localhost with 127.0.0.1 and remove SSL socket wrap…
ctoth b2ee2d2
refactor: Simplify logging and formatting in server and secureDesktop…
ctoth f620309
Use the Enum's value
ctoth 75190d5
Remove old static certificate
ctoth 9f6fbad
Ch-ch-ch-ch-changes
ctoth ec5f2d3
Braille secure desktop fix
ctoth 1c1511e
Better logging
ctoth 536f250
Use enum
ctoth f89daf4
Fix logging in server module
ctoth 1ca2b34
We don't need to register these Braille callbacks for anything but th…
ctoth f04591b
fix: Enforce TLS 1.2 minimum version for secure socket connections
ctoth 7589838
Include reference to PR in changelog.
ctoth 78bd453
fix: Update SSL context configuration for TLS 1.2 protocol
ctoth ccd466d
refactor: Rename variables and methods to follow camelCase convention
ctoth 4970137
Unmute remote speech when controlling the remote machine
ctoth dc43343
Added support for TOR hidden services (.onion addresses) per nvdaremo…
ctoth cffd9d8
Update docs
ctoth f8a7e11
Move contents of `socket_utils` into `protocol` module
ctoth ff3be26
Camel-case input module
ctoth d41ac91
Add copyright notices to all remote modules
ctoth 0d0859f
connection_info -> connectionInfo
ctoth 742f1f8
refactor: Add ABCMeta to Serializer for abstract base class definition
ctoth fb58036
globalVars.remoteClient -> remoteClient.client per review
ctoth 23317c1
remoteClient: Rename global 'client' variable to 'remoteClient'
ctoth f6f7da8
refactor(bridge): use RemoteMessageType enum for excluded messages
ctoth a62a94f
refactor: switch to StrEnum for connection enums
ctoth bdad80a
Standardize clipboard wave file naming per review
ctoth b12bfd4
Move alwaysCallAfter decorator to guiHelper module
ctoth 39f9ff3
Handle cases where the client is called (for instance by a gesture) a…
ctoth 68a1ebf
Update anchor
ctoth 3244d0b
Update Remote menu documentation
ctoth cd2be77
Update version mismatch error
ctoth 2a17049
refactor: Simplify Remote URL handling via slave + NVDA helper
ctoth ea4dd51
Add handleRemoteURL interface to nvdaControllerInternal
ctoth 654ce8d
Add handleRemoteURL function to nvdaControllerInternal
ctoth 0e352a5
refactor: Move beepSequence functionality to tones.py
ctoth 2b6af90
camel-case URL Handler
ctoth e736fb0
Update remote toggle gesture to NVDA+F11
ctoth 7102dda
Migrate remote settings into main config file
ctoth ac92db4
Update Docstring
ctoth 99a154c
Remove unnecessary import
ctoth 6a387f9
Log when no remote.ini is found
ctoth f0170df
Document mode in confspec
ctoth f564a08
Add min/max to mode
ctoth 399975c
Already Connected message
ctoth 07e9f92
fix message
ctoth 9058dc3
Add docs and types to remoteClient.connectionInfo
ctoth 1a37d36
Copyright headers
ctoth 12baa5b
camelCase settings attributes
ctoth 8b5d913
Remove trailing whitespace from nvdaControllerInternal_handleRemoteUR…
ctoth 3fd0ce8
Upcase `RemoteConnectionType` enum constants and add types and docstr…
ctoth 97942f9
Use f-string for ipv6
ctoth 715dbe2
f-string for host:port
ctoth 530dfb9
Improve transport guard
ctoth b47c258
Improve filter guard
ctoth fe7b4a4
Update copy link script
ctoth 8307fca
docs: Update documentation to Sphinx-style docstrings
ctoth 63543f2
docs: Update docstrings to use Sphinx-style formatting
ctoth 3fa9992
Use dict and set typing directly
ctoth 3f01593
f-string
ctoth c5f9298
Sphinx-style docs for `LocalMachine`
ctoth 2240854
URL Handler casing
ctoth 02f6c5c
Serializer Docstrings and import organization
ctoth 6f06127
f-string
ctoth 730ed6d
Camel-case cues
ctoth fcab4c2
f-string
ctoth c579ac1
f-string
ctoth 54389b0
Improve docs
ctoth a9e4e58
refactor: Update type hints to use modern Python syntax
ctoth 9aef15b
refactor: Update type hints for TCPTransport methods
ctoth bd44223
Naming and casing
ctoth 0c8e632
Script naming
ctoth ad93804
Script naming
ctoth b41ddf2
f-string
ctoth 4ca4181
Fix session imports
ctoth 28f6e25
Fix version mismatch log
ctoth 9a03336
F-string
ctoth ddcf880
refactor: improve type hints and documentation
ctoth bb1653d
Rename handleChannel_joined to handleChannelJoined
ctoth 02d8fe4
Typing for script gesture
ctoth cb188f1
Standardizing sphinx-style docs
ctoth 92ff5b0
camel-case process_key_input
ctoth d7b75d5
Docs and typing for transport and session
ctoth 0c0df36
Sphinx-style docs for `RelayTransport`
ctoth 79ad5d9
Docstring update
ctoth 387a91d
Better typing for URL Handler
ctoth a516090
Fix registry handler type annotations and variable naming in url handler
ctoth 79ef0f9
refactor: standardize naming conventions and type hints in RemoteClie…
ctoth 5410b99
secureDesktop: Create dedicated NVDA directory for IPC files
ctoth 5714783
Sphinx-style docs for server
ctoth e489eef
Apply feedback from server review
ctoth 45886f8
refactor: Improve type hints and client ID generation
ctoth 31f0292
Add explanatory comment
ctoth d7a2849
refactor: modernize type hints in remoteClient server
ctoth d24fca5
Add message if sending clipboard fails
ctoth dfa9d7e
Proper method to get temp path
ctoth 0467889
docs: improve secure desktop module documentation
ctoth 0880a78
Mark the global `RemoteClient` reference as private
ctoth 0c74ae3
tests: Add comprehensive unit tests for remote client functionality
ctoth 067d340
Renamed remoteClient.session.SlaveSession to remoteClient.session.Fol…
SaschaCowley c7dad5b
Renamed slaveSession to followerSession on remoteClient.client.Remote…
SaschaCowley 5d0dfd1
Renamed remoteClient.session.MasterSession to remoteClient.session.Le…
SaschaCowley ab6fbd7
Renamed slaveTransport to followerTransport in remoteClient.client.Re…
SaschaCowley 23cb747
Renamed masterTransport to leaderTransport in remoteClient.client.Rem…
SaschaCowley f387125
Renamed disconnectAsMaster to disconnectAsLeader in remoteClient.clie…
SaschaCowley 5378f72
Renamed disconnectAsSlave to disconnectAsFollower in remoteClient.cli…
SaschaCowley 70f95ba
Renamed onConnectAsMasterFailed to onConnectAsLeaderFailed in remoteC…
SaschaCowley 1540e24
Renamed connectAsMaster to connectAsLeader in remoteClient.client.Rem…
SaschaCowley 3aede4b
Renamed onConnectedAsMaster to onConnectedAsLeader in remoteClient.cl…
SaschaCowley ac72298
Renamed onDisconnectingAsMaster to onDisconnectingAsLeader in remoteC…
SaschaCowley ba2425d
Renamed onDisconnectedAsMaster to onDisconnectedAsLeader in remoteCli…
SaschaCowley d813d1e
Renamed connectAsSlave to connectAsFollower in remoteClient.client.Re…
SaschaCowley 81ef31b
Renamed onConnectedAsSlave to onConnectedAsFollower in remoteClient.c…
SaschaCowley 3e5f1b3
Renamed onDisconnectedAsSlave to onDisconnectedAsFollower in remoteCl…
SaschaCowley 32dbf6b
Renamed onMasterCertificateFailed to onLeaderCertificateFailed in rem…
SaschaCowley 2e557b0
Renamed onSlaveCertificateFailed to onFollowerCertificateFailed in re…
SaschaCowley 41b03d4
Renamed ConnectionMode.MASTER to ConnectionMode.LEADER in remoteClien…
SaschaCowley 68ef128
Renamed ConnectionMode.SLAVE to ConnectionMode.FOLLOWER in remoteClie…
SaschaCowley 8ecc6d0
Renamed _onMasterDisplayChange to _onLeaderDisplayChange in remoteCli…
SaschaCowley bbb07a2
Renamed masters to leaders in remoteClient.session.FollowerSession
SaschaCowley 576b68e
Renamed masterDisplaySizes to leaderDisplaySizes in remoteClient.sess…
SaschaCowley 6c8c714
Renamed hasBrailleMasters to hasBrailleLeaders in remoteClient.sessio…
SaschaCowley 8071eeb
Move remote tests into test_remote folder
ctoth 8b1d834
Renamed slaves to followers in remoteClient.session.LeaderSession
SaschaCowley f74a781
Replaced instances of master with leader in comments, docstrings and …
SaschaCowley c14c858
Replaced instances of slave with follower in comments, docstrings and…
SaschaCowley 8af09b8
Renamed hasSlaves to hasFollowers in remoteClient.session.LeaderSessi…
SaschaCowley fe5f0dd
Fixed more comments
SaschaCowley baf65f1
Replaced hardcoded "master" and "slave" with ConnectionMode.LEADER an…
SaschaCowley d26187c
Replaced hardcoded "master" with ConnectionMode.LEADER in handleClie…
SaschaCowley 937dc7f
Replaced existing instances of master and slave with leader and follo…
SaschaCowley 8dd7554
Merge branch 'remote' into removeMasterSlave
SaschaCowley 9e01097
Merge pull request #1 from nvda-art/removeMasterSlave
ctoth dfbbbec
Update copyright headers
SaschaCowley 0215cf9
Fixed some type hints
SaschaCowley 44ccf1f
Improved type hints for alwaysCallAfter
SaschaCowley a0e48f3
Fix issues in settings dialogs
SaschaCowley b19f716
Fixes to client
SaschaCowley 0c06432
Improvements in connection info
SaschaCowley 0b8f0e1
Typing and documentation fixes in bridge
SaschaCowley 3ed56fa
Fixes to dialogs
SaschaCowley 9c5f5c0
Fix some issues in dialogs
SaschaCowley d55f9d9
Typing and documentation fixes to input
SaschaCowley 8260b8b
Documentation improvements in local machine
SaschaCowley e008763
Code clean-up in menu and serializer
SaschaCowley 4a04794
Fixes to server
SaschaCowley 32d1711
Clean up in session
SaschaCowley 7a4f270
Misc clean-up
SaschaCowley 12f4654
Applied suggestions in server
SaschaCowley 5df5771
Added manual testing instructions of remote feature to tests/manual/r…
daiverd c2b4daf
Fixes to transport
SaschaCowley b61601e
Extract global variable
SaschaCowley 458f1b7
Improvements to user guide
SaschaCowley 671c078
Merge branch 'remote' of https://github.com/nvda-art/nvda into remote
SaschaCowley cb0586c
refactor: Improve transport run method
ctoth ea2243c
refactor: narrow type annotation for transport.send() to only accept …
ctoth a41edc4
Remove early return in cues preventing message
ctoth 2415c32
rename and camel-case
ctoth 2ff8d3c
Remove unused local_beep
ctoth dbbd4c2
Improve handleCertificateFailed method documentation and error handling
ctoth e879c2f
Fix logging port
ctoth 2f85daa
refactor(server): clarify socket listen backlog parameter
ctoth 1f4eeaf
Improve code clarity and documentation in remote client code
ctoth 3eee73a
Remove unused logging from url handler
ctoth ad6e912
Fixed several instances of snake_case
SaschaCowley c5a2416
Change to disconnected
SaschaCowley b95b615
Made select timeout a constant
SaschaCowley 96ef469
Update local relay server certificate
SaschaCowley d8793f4
Update changes
SaschaCowley 320365b
Merge branch 'master' into remote
SaschaCowley a758b58
lint fixes to Remote manual test plan
SaschaCowley 4cf3785
minor updates to tests
SaschaCowley 8ccb259
Make some constants enums and document where they come from
SaschaCowley 759cfd3
Fixed name of RemoteMessageType.PING
SaschaCowley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SaschaCowley marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.