Skip to content

Honour multi keypress timeout for NVDA key #17219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SaschaCowley merged 4 commits into from
Oct 1, 2024
Merged

Honour multi keypress timeout for NVDA key #17219

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
88d479c
Honour multi keypress delay for NVDA key
CyrilleB79 Sep 25, 2024
f4da469
Fix conversion factor
CyrilleB79 Sep 26, 2024
685fa5a
Pre-commit auto-fix
pre-commit-ci[bot] Sep 26, 2024
aed380f
Added brackets for clarity
SaschaCowley Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions source/keyboardHandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# A part of NonVisual Desktop Access (NVDA)
# This file is covered by the GNU General Public License.
# See the file COPYING for more details.
# Copyright (C) 2006-2023 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Babbage B.V., Cyrille Bougot
# Copyright (C) 2006-2024 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Babbage B.V., Cyrille Bougot

"""Keyboard support"""

Expand Down Expand Up @@ -203,7 +203,10 @@ def internal_keyDownEvent(vkCode, scanCode, extended, injected):
or (
keyCode == lastNVDAModifier
and lastNVDAModifierReleaseTime
and time.time() - lastNVDAModifierReleaseTime < 0.5
and (
time.time() - lastNVDAModifierReleaseTime
< config.conf["keyboard"]["multiPressTimeout"] / 1000
)
)
):
# The user wants the key to serve its normal function instead of acting as an NVDA modifier key.
Expand Down