Updating copying.txt using copying.md - #17196
Closed
dpy013 wants to merge 2 commits into
Closed
Conversation
Member
|
You'd also have to update every reference in NVDA, particularly copyright headers, to use the new file name / link. I don't think this is a good idea for now |
Collaborator
|
@seanbudd what about making the old file a reference to the new one, and update specific headers as PRs come through?
Could retain the content but with a note at the top.
"This file has moved ..."
|
Member
|
I don't think it's a good use of time but feel free to open an issue
…On Fri, Sep 20, 2024, 2:18 PM Luke Davis ***@***.***> wrote:
@seanbudd what about making the old file a reference to the new one, and
update specific headers as PRs come through?
Could retain the content but with a note at the top.
"This file has moved ..."
—
Reply to this email directly, view it on GitHub
<#17196 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWDBJR64WX7X2Z366T2BBLZXOO2FAVCNFSM6AAAAABORFWPI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRSG4ZDSNJWHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
|
@dpy013 I have no great interest, it was just an idea, but maybe that's a direction you could go.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
follow up #16830
Summary of the issue:
In pr 16830
copying.txt The markdown syntax has been used
Description of user facing changes
No user changes
Description of development approach
First the format of copying.txt was updated using copying.md
Secondly, also update the copying.txt reference in pyproject.toml to copying.md
Testing strategy:
Need to see if appveyor can be built successfully
Known issues with pull request:
Code Review Checklist:
@coderabbitai summary