Skip to content

Merge rc to beta #17069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 2 commits into from
Aug 29, 2024
Merged

Merge rc to beta #17069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09b3b49
[skip ci] Don't block GUI thread on add-on updates
seanbudd Aug 27, 2024
45301da
Merge remote-tracking branch 'origin/rc' into mergeRcToBeta
seanbudd Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/gui/addonStoreGui/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@
def initialize():
scheduleThread.scheduleDailyJobAtStartUp(
UpdatableAddonsDialog._checkForUpdatableAddons,
queueToThread=ThreadTarget.GUI,
queueToThread=ThreadTarget.DAEMON,
)
6 changes: 5 additions & 1 deletion source/gui/addonStoreGui/controls/messageDialogs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,4 +563,8 @@ def _checkForUpdatableAddons(cls):
addonsPendingUpdate = addonDataManager._addonsPendingUpdate()
if addonsPendingUpdate:
log.debug("updatable add-ons found")
displayDialogAsModal(cls(gui.mainFrame, addonsPendingUpdate))

def delayCreateDialog():
displayDialogAsModal(cls(gui.mainFrame, addonsPendingUpdate))

wx.CallAfter(delayCreateDialog)
2 changes: 1 addition & 1 deletion source/utils/schedule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ def callJobOnThread(*args, **kwargs): # noqa F811: lint bug with flake8 4.0.1 n
name=f"{task.__name__}",
)
log.debug(f"Starting thread for job: {task.__name__} on thread {t.ident}")
t.run()
t.start()
case ThreadTarget.CUSTOM:

def callJobOnThread(*args, **kwargs): # noqa F811: lint bug with flake8 4.0.1 not recognizing case statement
Expand Down
8 changes: 8 additions & 0 deletions user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,14 @@ Please refer to [the developer guide](https://www.nvaccess.org/files/nvda/docume
* These keys are currently synchronized until 2025.1.
* `NVDAObjects.UIA.InaccurateTextChangeEventEmittingEditableText` is deprecated with no replacement. (#16817, @LeonarddeR)

## 2024.3.1

This is a patch release to fix a bug with the automatic add-on update notification.

### Bug Fixes

* When automatically checking for add-on updates, NVDA no longer freezes on poor connections. (#17036)

## 2024.3

The Add-on Store will now notify you if any add-on updates are available on NVDA startup.
Expand Down