Run pre-commit on all files - #16936
Merged
Merged
Conversation
seanbudd
commented
Aug 1, 2024
seanbudd
commented
Member
- Update Ruff to 0.5.5
- Fix E721, as now detected by ruff
- Run ruff format
- Add trailing commas
- Fix whitespaces (trailing, end of file new lines)
- Update .git-blame-ignore-revs with these commits
See test results for failed build of commit 036d469d27 |
seanbudd
added a commit
that referenced
this pull request
Aug 1, 2024
Part of #10516 Summary of the issue: As a developer, I would like automation tools to fix the lint of my code when I open a PR. After #16936, we have applied pre-commit on all files. However, there are no automation checks for some of these checks (like whitespaces changes). Which means without running pre-commit automatically, the repository may have pre-commit regressions. Description of user facing changes Improved documentation for pre-commit hooks and the PR contribution process. Description of development approach Setup Pre-commit CI. This is a CI/CD tool to automatically apply pre-commit to PRs.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.