Skip to content

Beta to master - #16928

Merged
seanbudd merged 16 commits into
masterfrom
beta
Jul 30, 2024
Merged

Beta to master#16928
seanbudd merged 16 commits into
masterfrom
beta

Conversation

@seanbudd

Copy link
Copy Markdown
Member

@coderabbitai ignore

NVDA translation automation and others added 16 commits July 26, 2024 00:01
From translation svn revision: 82771

Authors:
Fatma Mehanna <fatma.mehanna@gmail.com>
Shaimaa Ibrahim <shamse1@gmail.com>
Abdelkrim Bensaid <abdelkrim.bensaid@free.fr>
Omar Alojaimi <amrahmad1995@gmail.com>

Stats:
105	26	user_docs/ar/userGuide.md
 1 file changed, 105 insertions(+), 26 deletions(-)
From translation svn revision: 82771

Authors:
Zahari Yurukov <zahari.yurukov@gmail.com>
Kostadin Kolev <k.kolev1985@gmail.com>

Stats:
102	0	user_docs/bg/changes.md
104	16	user_docs/bg/userGuide.md
 2 files changed, 206 insertions(+), 16 deletions(-)
From translation svn revision: 82771

Authors:
Daniel K. Gartmann <kontakt@nvda.dk>
Nicolai Svendsen <chojiro1990@gmail.com>
bue@vester-andersen.dk

Stats:
26	9	user_docs/da/userGuide.md
 1 file changed, 26 insertions(+), 9 deletions(-)
From translation svn revision: 82771

Authors:
Juan C. buno <oprisniki@gmail.com>
Noelia Martinez <nrm1977@gmail.com>
Remy Ruiz <remyruiz@gmail.com>
Jose M. Delicado <jm.delicado@nvda.es>

Stats:
2	1	user_docs/es/changes.md
 1 file changed, 2 insertions(+), 1 deletion(-)
From translation svn revision: 82771

Authors:
Juan C. buno <oprisniki@gmail.com>
Ivan Novegil <ivan.novegil@nvda.es>
Javier Curras <javier.curras@nvda.es>
Jose M. Delicado <jm.delicado@nvda.es>

Stats:
2	1	user_docs/gl/changes.md
 1 file changed, 2 insertions(+), 1 deletion(-)
From translation svn revision: 82771

Authors:
Takuya Nishimoto <nishimotz@gmail.com>
Minako Nonogaki <minakonono3519@gmail.com>

Stats:
103	1	user_docs/ja/changes.md
2	2	user_docs/ja/userGuide.md
 2 files changed, 105 insertions(+), 3 deletions(-)
From translation svn revision: 82771

Authors:
Joseph Lee <joseph.lee22590@gmail.com>
Chang-Hwan Jang <462356@gmail.com>
Dong Hee Park <hi@aheu.org>
Stanley Chung <stanley@mail.com>

Stats:
101	0	user_docs/ko/changes.md
18	9	user_docs/ko/userGuide.md
 2 files changed, 119 insertions(+), 9 deletions(-)
From translation svn revision: 82771

Authors:
Zvonimir Stanecic <zvonimirek222@yandex.com>
Aleksandr Lin'kov <kvark128@yandex.ru>

Stats:
89	89	user_docs/ru/changes.md
1	1	user_docs/ru/userGuide.md
 2 files changed, 90 insertions(+), 90 deletions(-)
From translation svn revision: 82771

Authors:
Cagri Dogan <cagrid@hotmail.com>

Stats:
103	0	user_docs/tr/changes.md
102	14	user_docs/tr/userGuide.md
 2 files changed, 205 insertions(+), 14 deletions(-)
From translation svn revision: 82771

Authors:
Dang Hoai Phuc <danghoaiphuc@gmail.com>
Nguyen Van Dung <dungnv1984@gmail.com>

Stats:
87	0	user_docs/vi/changes.md
105	17	user_docs/vi/userGuide.md
 2 files changed, 192 insertions(+), 17 deletions(-)
From translation svn revision: 82771

Authors:
vgjh2005@gmail.com
jiangtiandao901647@gmail.com
manchen_0528@outlook.com
dingpengyu06@gmail.com
singer.mike.zhao@gmail.com
1872265132@qq.com

Stats:
1	1	user_docs/zh_CN/userGuide.md
 1 file changed, 1 insertion(+), 1 deletion(-)
From translation svn revision: 82771

Authors:
wangjanli@gmail.com
maro.zhang@gmail.com
Aaron Wu <waaron2000@gmail.com>
Victor Cai <surfer0627@gmail.com>
haach111000@gmail.com

Stats:
196	163	source/locale/zh_TW/characterDescriptions.dic
28	2	source/locale/zh_TW/symbols.dic
 2 files changed, 224 insertions(+), 165 deletions(-)
From translation svn revision: 82771
…n to factory defaults when using the NVDA+control+r command (#16919)

fixes #16896

Summary of the issue:
Sometimes, when pressing the NVDA+control+r command three times, NVDA wouldn't reset the configuration to factory defaults, but instead produce the following error
ERROR - keyboardHandler.internal_keyDownEvent (10:14:40.187) - winInputHook (13232):
internal_keyDownEvent
Traceback (most recent call last):
File "keyboardHandler.pyc", line 245, in internal_keyDownEvent
File "inputCore.pyc", line 535, in executeGesture
AttributeError: 'NoneType' object has no attribute 'suppressClearBrailleRegions'

Description of user facing changes
The user will reliably be able to reset the configuration to factory defaults with the NVDA+control+r command

Description of development approach
the suppressCancelSpeech function is only defined and called if braille.handler is not None, otherwise, speech.cancelSpeech is called
@seanbudd
seanbudd requested a review from a team as a code owner July 30, 2024 05:58
@seanbudd
seanbudd requested a review from gerald-hartig July 30, 2024 05:58
@seanbudd
seanbudd merged commit 24a7261 into master Jul 30, 2024
@LeonarddeR

Copy link
Copy Markdown
Collaborator

For reference, this didn't lint correctly as far as I can see. We should ensure that the linter/formatter runs on beta to master and master to beta merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants