Skip to content

Remove carriage return and bell character from table header information in IAccessible MS Word #16874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 4 commits into from
Jul 19, 2024
Merged

Remove carriage return and bell character from table header information in IAccessible MS Word #16874

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45ff65b
Strip carriage return and bell from the end of row and column headers…
SaschaCowley Jul 17, 2024
6f33694
Added change log entry
SaschaCowley Jul 17, 2024
4b167c0
Update user_docs/en/changes.md
SaschaCowley Jul 18, 2024
7566a95
Merge branch 'master' into filterBellWordTableHeaders
SaschaCowley Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions source/NVDAObjects/IAccessible/winword.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,8 @@ def fetchAssociatedHeaderCellText(self, cell, columnHeader=False):
tempColumnNumber -= 1
continue
break
textList.append(headerCell.range.text)
# 7212: Filter the carriage return and bell character from header text.
textList.append(headerCell.range.text.removesuffix("\r\a"))
Comment thread
SaschaCowley marked this conversation as resolved.
Resolved
else:
for headerColumnNumber in range(info.columnNumber, info.columnNumber + info.colSpan):
tempRowNumber = rowNumber
Expand All @@ -230,7 +231,8 @@ def fetchAssociatedHeaderCellText(self, cell, columnHeader=False):
tempRowNumber -= 1
continue
break
textList.append(headerCell.range.text)
# 7212: Filter the carriage return and bell character from header text.
textList.append(headerCell.range.text.removesuffix("\r\a"))
text = " ".join(textList)
if text:
return text
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
* NVDA once again relies on events for caret movement in several cases, rather than only on manual querying of the caret position.
* UIA for XAML and WPF text controls. (#16817, @LeonarddeR)
* IAccessible2 for browsers such as Firefox and Chromium based browsers. (#11545, #16815, @LeonarddeR)
* When accessing Microsoft Word without UI Automation, NVDA no longer outputs garbage characters in braille as part of table header information defined with the set row header and set column header commands. (#7212)
Comment thread
SaschaCowley marked this conversation as resolved.
Resolved


### Changes for Developers
Expand Down