Skip to content

Revert "ia2TextMozilla: expose name as content for any non-contenteditable within a contenteditable. Required to report addresses in outlook.com / Modern Outlook To/CC/BCC fields." #16859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelDCurran merged 1 commit into from
Jul 15, 2024
Merged

Revert "ia2TextMozilla: expose name as content for any non-contenteditable within a contenteditable. Required to report addresses in outlook.com / Modern Outlook To/CC/BCC fields." #16859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions source/NVDAObjects/IAccessible/ia2TextMozilla.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,16 +80,6 @@ def _getControlFieldForObject(self, obj, ignoreEditableText=True):
uniqueID = obj.IA2UniqueID
if uniqueID is not None:
controlField["uniqueID"] = uniqueID
# #16631: Outlook.com /modern Outlook represent addresses in To/CC/BCC fields as labelled buttons.
# These buttons are non-contenteditable within a parent contenteditable.
# Ensure their label (name) is reported as the content
# as the caret cannot move through them.
if (
controlTypes.state.State.EDITABLE not in obj.states
and obj.parent
and controlTypes.state.State.EDITABLE in obj.parent.states
):
controlField['content'] = obj.name
return controlField

def _isCaretAtEndOfLine(self, caretObj: IAccessible) -> bool:
Expand Down
1 change: 0 additions & 1 deletion user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ A warning message will inform you if you try writing to a non-empty directory. (
* Speech is no longer silent after disconnecting from and reconnecting to a Remote Desktop session. (#16722, @jcsteh)
* Support added for text review commands for an object's name in Visual Studio Code. (#16248, @Cary-Rowen)
* Playing NVDA sounds no longer fails on a mono audio device. (#16770, @jcsteh)
* NVDA will report addresses when arrowing through To/CC/BCC fields in outlook.com / Modern Outlook. (#16856)
* NVDA now handles add-on installation failures more gracefully. (#16704)

### Changes for Developers
Expand Down