Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an older version of setuptools when installing requirements #16587

Merged
merged 1 commit into from
May 23, 2024

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented May 22, 2024

Link to issue number:

None

Summary of the issue:

setuptools has been updated, breaking support with py2exe: py2exe/py2exe#208.

When installing packages, pip automatically pulls in the latest build dependences as specified in PEP 518.
pip creates a custom temporary build environment to install packages using the latest pip environment.

Description of development approach

Create a pyproject.toml to specify the build environment we are using.
https://packaging.python.org/en/latest/guides/writing-pyproject-toml/

Use the flag no-build-isolation when installing requirements.txt.
This prevent pip from using the custom build environment and automatically pulling the latest setuptools when installing packages.

As such, we need to manually install the desired version of setuptools, and manually install pip's dependency wheel.
https://stackoverflow.com/questions/62889093/what-does-no-build-isolation-do

Testing strategy:

Ensure build completes successfully

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner May 22, 2024 05:09
@seanbudd seanbudd requested a review from SaschaCowley May 22, 2024 05:09
@AppVeyorBot
Copy link

  • Build execution time has reached the maximum allowed time for your plan (60 minutes).

See test results for failed build of commit 2b613c8d37

@CyrilleB79
Copy link
Collaborator

Isn't there any impact for local builds?

@AppVeyorBot
Copy link

  • Build execution time has reached the maximum allowed time for your plan (60 minutes).

See test results for failed build of commit d5f845a906

@seanbudd seanbudd force-pushed the fixAppVeyorSetuptools branch from fb2203a to c5937cf Compare May 23, 2024 00:54
@seanbudd seanbudd changed the base branch from master to beta May 23, 2024 00:54
@seanbudd seanbudd force-pushed the fixAppVeyorSetuptools branch from ef6026e to a79f3c7 Compare May 23, 2024 01:51
@seanbudd seanbudd force-pushed the fixAppVeyorSetuptools branch from a79f3c7 to 43ae054 Compare May 23, 2024 02:16
@seanbudd seanbudd changed the title Pin setuptools before updating pip Use an older version of setuptools when installing requirements May 23, 2024
@seanbudd
Copy link
Member Author

@CyrilleB79 - yes there may be, the current approach should fix this for local environments. I haven't been able to reproduce this locally so I cannot confirm.

@seanbudd
Copy link
Member Author

@dpy013 - we will likely have to migrate from py2exe due to no python 3.12 support.
This is out of scope of this PR, we need to fix the build system immediately and this is a large project.

py2exe/py2exe#191

@seanbudd seanbudd merged commit 8caf17c into beta May 23, 2024
3 checks passed
@seanbudd seanbudd deleted the fixAppVeyorSetuptools branch May 23, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants