Skip to content

If command for report the note on the current Excel cell pressed twice, presents the information in browse mode #15986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tseykovets wants to merge 4 commits into from
+20 −4
Closed

If command for report the note on the current Excel cell pressed twice, presents the information in browse mode #15986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
522b8d3
If command for report the note on the current Excel cell pressed twic…
tseykovets Dec 30, 2023
6d1dad4
Apply suggestions from code review
seanbudd Jan 2, 2024
3db8636
Fix a bug with handling script repeats
tseykovets Jan 2, 2024
9232132
Reformulate the description of the changes
tseykovets Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions source/NVDAObjects/window/excel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1679,8 +1679,11 @@ def _get_positionInfo(self):
# In Office 2016, 365 and newer, comments are now called notes.
# Thus, messages dialog title and so on should refer to notes.
@script(
# Translators: the description for a script for Excel
description=_("Reports the note on the current cell"),
description=_(
# Translators: the description for a script for Excel
"Reports the note on the current cell. "
"If pressed twice, presents the information in browse mode"
),
gesture="kb:NVDA+alt+c",
category=SCRCAT_SYSTEMCARET,
speakOnDemand=True,
Expand All @@ -1689,7 +1692,15 @@ def script_reportComment(self,gesture):
commentObj=self.excelCellObject.comment
text=commentObj.text() if commentObj else None
if text:
ui.message(text)
repeats = scriptHandler.getLastScriptRepeatCount()
if repeats == 0:
ui.message(text)
elif repeats == 1:
ui.browseableMessage(
text,
# Translators: title for note on the current Excel cell dialog.
_("Note")
)
else:
# Translators: A message in Excel when there is no note
ui.message(_("Not on a note"))
Expand Down
4 changes: 4 additions & 0 deletions user_docs/en/changes.t2t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ What's New in NVDA


== Changes ==
- Microsoft Office:
- Excel: When "report any notes for the currently focused cell" (NVDA+alt+c) is pressed twice, the information is shown in a window. (#15986, @tseykovets)
-
-


== Bug Fixes ==
Expand Down
3 changes: 2 additions & 1 deletion user_docs/en/userGuide.t2t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1255,7 +1255,8 @@ Selecting a form field and pressing enter or the Move to button moves to that fi

+++ Reporting Notes +++[ExcelReportingComments]
%kc:beginInclude
To report any notes for the currently focused cell, press NVDA+alt+c.
To report any notes for the currently focused cell, press ``NVDA+alt+c``.
Pressing twice shows the information in a window.
In Microsoft 2016, 365 and newer, the classic comments in Microsoft Excel have been renamed to "notes".
%kc:endInclude
All notes for the worksheet can also be listed in the NVDA Elements List after pressing NVDA+f7.
Expand Down